Added HTTP code 423 Locked #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -32,6 +32,7 @@ Lead Maintainer: [Adam Bretz](https://github.com/arb) | |||
| - [`Boom.rangeNotSatisfiable([message], [data])`](#boomrangenotsatisfiablemessage-data) | |||
| - [`Boom.expectationFailed([message], [data])`](#boomexpectationfailedmessage-data) | |||
| - [`Boom.badData([message], [data])`](#boombaddatamessage-data) | |||
| - [`Boom.locked([message], [data])`](#boomlockedmessage-data) | |||
There was a problem hiding this comment.
Remove this; the TOC is auto generated on version bumps.
| - `data` - optional additional error data. | ||
|
|
||
| ```js | ||
| Boom.locked('this account has been locked and it is your fault'); |
There was a problem hiding this comment.
the it is your fault is a bit harsh 😄
There was a problem hiding this comment.
Agreed. Not sure "account" is strictly necessary either. Why not just:
- The resource that is being accessed is locked
- This resource has been locked
There was a problem hiding this comment.
Sounds good! (I know this is just an example but people look at this as an example so...)
There was a problem hiding this comment.
Haha, fair enough :P
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to #111, this adds
boom.locked()which returns the 423 Locked response.