Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added HTTP code 423 Locked #112

Merged
merged 3 commits into from May 20, 2016

Conversation

@jsonmaur
Copy link
Contributor

jsonmaur commented May 19, 2016

In response to #111, this adds boom.locked() which returns the 423 Locked response.

Jason Maurer
README.md Outdated
@@ -32,6 +32,7 @@ Lead Maintainer: [Adam Bretz](https://github.com/arb)
- [`Boom.rangeNotSatisfiable([message], [data])`](#boomrangenotsatisfiablemessage-data)
- [`Boom.expectationFailed([message], [data])`](#boomexpectationfailedmessage-data)
- [`Boom.badData([message], [data])`](#boombaddatamessage-data)
- [`Boom.locked([message], [data])`](#boomlockedmessage-data)

This comment has been minimized.

Copy link
@arb

arb May 19, 2016

Contributor

Remove this; the TOC is auto generated on version bumps.

This comment has been minimized.

Copy link
@jsonmaur

jsonmaur May 20, 2016

Author Contributor

Good to know.

Jason Maurer
README.md Outdated
- `data` - optional additional error data.

```js
Boom.locked('this account has been locked and it is your fault');

This comment has been minimized.

Copy link
@AdriVanHoudt

AdriVanHoudt May 20, 2016

Contributor

the it is your fault is a bit harsh 😄

This comment has been minimized.

Copy link
@mtharrison

mtharrison May 20, 2016

Member

Agreed. Not sure "account" is strictly necessary either. Why not just:

  • The resource that is being accessed is locked
  • This resource has been locked

This comment has been minimized.

Copy link
@AdriVanHoudt

AdriVanHoudt May 20, 2016

Contributor

Sounds good! (I know this is just an example but people look at this as an example so...)

This comment has been minimized.

Copy link
@jsonmaur

jsonmaur May 20, 2016

Author Contributor

Haha, fair enough :P

Jason Maurer
@arb arb added this to the 3.2.0 milestone May 20, 2016
@arb arb self-assigned this May 20, 2016
@arb arb added the feature label May 20, 2016
@arb arb merged commit c3b3c6b into hapijs:master May 20, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.