4.2.2 regression — cannot connect to Redis server

[mshick]

I've encountered a regression between 4.2.1 and 4.2.2, where suddenly my servers are unable to connect to my redis instance. This is replicated in two environments, locally (in docker containers) and in my CI environment.

Is there some major change that could account for this? I currently pass a config object like this:

    cache: [
      {
        engine: 'catbox-redis',
        url: redis://:pass@redis:6379
      }
    ]

[mshick]

I've traced the problem to this line: https://github.com/hapijs/catbox-redis/blob/master/lib/index.js#L33

Specifically it appears that the new approach to providing settings is not allowing the url is not compatible with the way ioredis now takes config: https://github.com/luin/ioredis#connect-to-redis

You'll see that you would have to either provide a connection URL string, or a connection object. You are simply passing { url: 'redis://:pass@redis:6379' } directly to ioredis.

I was able to solve my issue by converting the URL string into a connection object before passing to catbox-redis.

[marcuspoehls]

Hi Michael, thank you for reporting this!

Seems like a breaking change to existing setups that use the connection string.

I'll have a look at this next week and fix it. This should be fixable on catbox-redis side.

PS: I'm on vacation this week.
PPS: if you want to submit a PR, please feel free 😊

[marcuspoehls]

@mshick Hey Michael, I’ve tagged release 4.2.3 to address this issue. Thank you for reporting 🤝👍

[mshick]

@marcuspoehls Thanks for addressing. Sorry I didn't do that PR — I just worked around in my own code and had to move on.

[marcuspoehls]

@mshick No problem! I hope this issue didn’t cause much trouble for you. Have a great day!

[lock]

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.