Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog? #92

Closed
aredridel opened this issue Oct 6, 2016 · 4 comments
Closed

Changelog? #92

aredridel opened this issue Oct 6, 2016 · 4 comments
Assignees
Labels
support Questions, discussions, and general support

Comments

@aredridel
Copy link

What changed in Code 3? What changed in Code 4?

I've got a project on code 2, and it'd be nice to know what I've got to update. I couldn't find a changelog, and certainly not a list of breaking changes.

@devinivy
Copy link
Member

devinivy commented Oct 6, 2016

We rely on diligent milestoning and tagging to document changes. Here's a search that should help! https://github.com/hapijs/code/issues?utf8=%E2%9C%93&q=label%3A%22breaking%20changes%22

In short, code v3 introduces to.shallow.equal() and makes equal() deep by default. I'm actually not familiar with the changes in code v4, but my impression is that it's a subtle change that is not likely to affect many tests.

@cjihrig
Copy link
Contributor

cjihrig commented Oct 6, 2016

The changes all go into milestones. These are the changes for 3.0.0 and 4.0.0.

For v3, see #73, which changes comparisons to be deep by default.

For v4, see 88a5d24, which only effects include() and the part flag.

@cjihrig cjihrig closed this as completed Oct 6, 2016
@cjihrig cjihrig self-assigned this Oct 6, 2016
@aredridel
Copy link
Author

That'll do, I guess. Never woulda found that from any of the entry points. Still hard to tell what changed and what I need to do to update for 4. That commit message doesn't explain much.

@Marsup Marsup added the support Questions, discussions, and general support label Sep 20, 2019
@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
support Questions, discussions, and general support
Projects
None yet
Development

No branches or pull requests

4 participants