Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change default comparison behavior #73

Merged
merged 1 commit into from
May 20, 2016
Merged

change default comparison behavior #73

merged 1 commit into from
May 20, 2016

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented May 19, 2016

This changes the default equality behavior in the following ways:

  • drop the deep flag. This is now the default behavior.
  • add shallow flag. This performs strict equality comparisons.
  • comparePrototypes now defaults to false.

Closes #68

- drop the `deep` flag. This is now the default behavior.
- add `shallow` flag. This performs strict equality comparisons.
- `comparePrototypes` now defaults to false.
@cjihrig cjihrig added the breaking changes Change that can breaking existing code label May 19, 2016
@hueniverse hueniverse added this to the 2.3.1 milestone May 20, 2016
@hueniverse hueniverse merged commit 00f72e7 into hapijs:master May 20, 2016
@cjihrig cjihrig mentioned this pull request Oct 6, 2016
@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking changes Change that can breaking existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default to deep copy
2 participants