Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix equal() types #173

Merged
merged 2 commits into from Jan 24, 2022
Merged

Fix equal() types #173

merged 2 commits into from Jan 24, 2022

Conversation

hueniverse
Copy link
Contributor

@hueniverse hueniverse commented Jan 24, 2022 •
edited

Fixes #172

@hueniverse hueniverse added bug Bug or defect types TypeScript type definitions labels Jan 24, 2022
@hueniverse hueniverse added this to the 8.0.6 milestone Jan 24, 2022
@hueniverse hueniverse changed the title Fix #172 Fix equal() types Jan 24, 2022
kanongil
kanongil approved these changes Jan 24, 2022
View reviewed changes
Copy link
Contributor

@kanongil kanongil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is quite restricted. Makes sense to to apply Loosely to handle common cases.

@devinivy devinivy self-assigned this Jan 24, 2022
@devinivy devinivy merged commit 1091528 into master Jan 24, 2022
@devinivy devinivy deleted the 172 branch January 24, 2022 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanongil kanongil kanongil approved these changes

@devinivy devinivy devinivy approved these changes

Assignees

@devinivy devinivy

Labels
bug Bug or defect types TypeScript type definitions
Projects
None yet
Milestone
8.0.6
Development

Successfully merging this pull request may close these issues.

equal(value: T) type should be Loosely<T> when options ignore symbols or properties
3 participants
@hueniverse @kanongil @devinivy