Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename plugin options to be consistent across the hapi ecosystem #236

Merged
merged 1 commit into from Mar 29, 2022
Merged

Rename plugin options to be consistent across the hapi ecosystem #236

merged 1 commit into from Mar 29, 2022

Conversation

spridev
Copy link
Contributor

@spridev spridev commented Feb 11, 2021

The hapi ecosystem offers the following official authentication plugins:

  • basic: uses validate and isValid (reference)
  • jwt: uses validate and isValid (reference)
  • cookie: uses validateFunc and valid (reference)
  • bell: does not use a validation function

This merge request aims to make these options consistent across all plugins.

@devinivy devinivy added the breaking changes Change that can breaking existing code label Feb 12, 2021
@devinivy devinivy added this to the 12.0.0 milestone Mar 29, 2022
@devinivy devinivy changed the base branch from master to v12 March 29, 2022 02:06
@devinivy
Copy link
Member

This is going into a branch for v12. Thanks!

@devinivy devinivy merged commit 9dcbb16 into hapijs:v12 Mar 29, 2022
@spridev spridev deleted the naming branch March 29, 2022 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking changes Change that can breaking existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants