Fix clearInvalid (for issue #34) #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hueniverse
pushed a commit
that referenced
this pull request
Nov 20, 2014
Fix clearInvalid (for issue #34)
|
Next time don't change the version. That's part of the release process. Good catch on the cause. Thanks. |
|
My bad, I'll remember that. Not positive that test case is 100% the right way to do it either. Took me a minute to figure out a valid way. |
|
Most of the test wasn't needed. You just need to setup the strategy and then send a bad cookie to get a clear response. I changed it. |
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a test case for clearInvalid cookie code when you change the password between server restarts (or in the case of the test a 2nd server is created) and fixes the code to properly pass the configuration value on to the internal clone. Also bumped the version number to cover the change.