Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clearInvalid (for issue #34) #37

Merged
merged 1 commit into from Nov 20, 2014

Conversation

@jdarling
Copy link

jdarling commented Nov 20, 2014

This adds a test case for clearInvalid cookie code when you change the password between server restarts (or in the case of the test a 2nd server is created) and fixes the code to properly pass the configuration value on to the internal clone. Also bumped the version number to cover the change.

Jeremy Darling
@jdarling jdarling changed the title Fix clearInvalid #34 Fix clearInvalid (for issue #34) Nov 20, 2014
hueniverse added a commit that referenced this pull request Nov 20, 2014
Fix clearInvalid (for issue #34)
@hueniverse hueniverse merged commit 58e7a80 into hapijs:master Nov 20, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
@hueniverse hueniverse added the bug label Nov 20, 2014
@hueniverse hueniverse added this to the 1.4.1 milestone Nov 20, 2014
@hueniverse hueniverse self-assigned this Nov 20, 2014
@hueniverse

This comment has been minimized.

Copy link
Member

hueniverse commented Nov 20, 2014

Next time don't change the version. That's part of the release process. Good catch on the cause. Thanks.

@jdarling

This comment has been minimized.

Copy link
Author

jdarling commented Nov 20, 2014

My bad, I'll remember that. Not positive that test case is 100% the right way to do it either. Took me a minute to figure out a valid way.

@hueniverse

This comment has been minimized.

Copy link
Member

hueniverse commented Nov 20, 2014

Most of the test wasn't needed. You just need to setup the strategy and then send a bad cookie to get a clear response. I changed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.