Added function support on plugins registration #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed package.json to version 4.1.1
|
This is for issue #89 |
csrl
reviewed
Apr 5, 2017
| server.start(() => { | ||
|
|
||
| console.log('hapi days!'); | ||
| plugin = require('./awesome-plugin.js'); |
There was a problem hiding this comment.
The coding style does not conform to https://github.com/hapijs/contrib/blob/master/Style.md
csrl
reviewed
Apr 5, 2017
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "name": "glue", | |||
| "description": "Server composer for hapi.js", | |||
| "version": "4.1.0", | |||
| "version": "4.1.1", | |||
There was a problem hiding this comment.
@csrl I will revert does changes and make a new pull request. I will let you know about this tonight.
|
I would love to see this change merged? Is it still in the works? |
|
It was implemented in #95 and released in v4.2 |
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi I add function support on registrations: [{plugin: require('./my-awesome-plugin.js')}] because some times to use things like server rendering is needed that webpack or something like that parse imports/require it self.
Also let people do it with his own require/import logic.