Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved filter option to also filter `query` #433

Merged
merged 1 commit into from Feb 10, 2016
Merged

Conversation

@catalint
Copy link
Contributor

catalint commented Feb 5, 2016

Filter option now filters query also

use case: access_token in query land

@arb

This comment has been minimized.

Copy link
Contributor

arb commented Feb 5, 2016

Is that really sensitive information though? If it is, it probably shouldn't be on the query string.

@catalint

This comment has been minimized.

Copy link
Contributor Author

catalint commented Feb 5, 2016

It's not sensitive but it's long, repetitive, and takes up storage/screen space

Other usecase I can think of now can be to remove ?random=234234241324 or ?_utm (google analytics)

I used the "remove" filter option on my side, but left "censor" to make it easier to grasp what's happening for new users

@arb arb self-assigned this Feb 10, 2016
@arb arb added the feature label Feb 10, 2016
@arb arb added this to the 6.6.0 milestone Feb 10, 2016
arb added a commit that referenced this pull request Feb 10, 2016
Improved filter option to also filter `query`
@arb arb merged commit b9577bb into hapijs:master Feb 10, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.