Proxing changes cache-control from public to private

[thomaspeklak]

I am trying to proxy an endpoint with hapi that provides a cache control header (max-age=30, must-revalidate, public). When I specify a simple onResponse handler with reply(res) (see below) all headers are passed correctly. Removing this handler and letting hapi do the work, results in a cache-control header of no-cache.

This was expected. I need to specify ttl: "upstream" in the route config, to pass along the cache headers. But then the cache-control header changes from public to private: 'max-age=30, must-revalidate, private'``

Dumb onResponseHandler:

function (err, res, req, reply, settings, ttl) {
    reply(res);
};

[osukaa]

Are you specifying the passThrough options? Since it defaults to false it won't pass the headers.

passThrough - if set to true, it forwards the headers from the client to the upstream service, headers sent from the upstream service will also be forwarded to the client. Defaults to false.

[thomaspeklak]

Ok, this would solve the problem with the cache headers. But I do not really want to have the proxy pass all headers from the client to the upstream.

I do specify my custom headers in a mapUri, does this overwrite the passthrough option in the upstream direction?

[osukaa]

Yes, if you send the custom headers it will overwrite the ones of the original request even if the passThrough flag is set to true

[thomaspeklak]

Shall i enhance the documentation to make this clearer? If yes, is this more a hapi or an h2o2 issue?

[osukaa]

I think the documentation should be here. Send a PR :)

[osukaa]

@thomaspeklak I'll close this issue and you can create a new one with a PR

[lock]

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.