Throwing in handler crashes the server, but not in all cases

[matthieusieben]

If you have a route, that has a pre handler that returns a native Node promise and if an Exception is thrown from the main handler, the server crashes:

const Hapi = require('hapi');

var server = new Hapi.Server();

server.connection({
    port: 3000
});


server.method('promiseMethod', () => Promise.resolve('result'), { callback: false })
server.method('callbackMethod', (next) => next('result'))

server.route({
    method: 'GET',
    path: '/willCrash',
    config: {
        pre: [
            { method: 'promiseMethod()' },
        ]
    },
    handler: function(request, reply){
        throw new Error('Oops');
    }
});
server.route({
    method: 'GET',
    path: '/wontCrash',
    config: {
        pre: [
            { method: 'callbackMethod()' },
        ]
    },
    handler: function(request, reply){
        throw new Error('Oops');
    }
});

server.start(() => {
    console.log('Server listening ...')
})

The server will crash when a GET request is made on /willCrash but not on /wontCrash. Note that it is not the case when Bluebird promises are used instead.

This issue can be fixed using #3196, even though the right solution might be more profound.

[Marsup]

Already fixed by #3202.

[rmedaer]

It seems that this is the same issue than here : #3196

To be confirmed...