Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v17 fails to include response payload in POST requests #4226

Closed
hueniverse opened this issue Feb 1, 2021 · 0 comments
Closed

v17 fails to include response payload in POST requests #4226

hueniverse opened this issue Feb 1, 2021 · 0 comments
Assignees
Labels
bug Bug or defect commercial Backport for commercially licensed version
Milestone

Comments

@hueniverse
Copy link
Contributor

The combination of an incoming HTTP POST request and the changes to node's close event make this case look like the request failed to transmit. The solution is to refactor the code per version 18 and newer, but for v17, just going to patch it so it passes the information. It may cause failed requests (closed early) to show as transmitted (request.response) will be present, but that's acceptable side effect.

@hueniverse hueniverse added bug Bug or defect commercial Backport for commercially licensed version labels Feb 1, 2021
@hueniverse hueniverse self-assigned this Feb 1, 2021
@hueniverse hueniverse added this to the 17.9.4 milestone Feb 1, 2021
hueniverse added a commit that referenced this issue Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug or defect commercial Backport for commercially licensed version
Projects
None yet
Development

No branches or pull requests

1 participant