Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move router to Call #1944

Merged
merged 6 commits into from
Sep 15, 2014
Merged

Move router to Call #1944

merged 6 commits into from
Sep 15, 2014

Conversation

hueniverse
Copy link
Contributor

Closes #1943

@hueniverse hueniverse added the dependency Update module dependency label Sep 14, 2014
@hueniverse hueniverse added this to the 6.8.2 milestone Sep 14, 2014
@geek geek self-assigned this Sep 15, 2014
geek
geek reviewed Sep 15, 2014
View reviewed changes
docs/Reference.md
@@ -1470,6 +1470,7 @@ Each request object has the following properties:
- `remotePort` - remote client port.
- `referrer` - content of the HTTP 'Referrer' (or 'Referer') header.
- `host` - content of the HTTP 'Host' header.
- `hostname` - the hostname part of the 'Host' header.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should try to clarify the difference between this and the host header.

     - `host` - the raw value of the HTTP 'Host' header.
    - `hostname` - the hostname part of the 'Host' header.  The `host` header without the port.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

geek added a commit that referenced this pull request Sep 15, 2014
@geek
Merge pull request #1944 from hapijs/router
617da34 
Move router to Call
@geek geek merged commit 617da34 into master Sep 15, 2014
@geek geek deleted the router branch September 15, 2014 21:45
@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@geek geek

Labels
dependency Update module dependency
Projects
None yet
Milestone
6.9.0
Development

Successfully merging this pull request may close these issues.

Move routing login out to call
2 participants
@hueniverse @geek