Allow custom encoders to validate compression options #3319
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While implementing support for the new route level
compression
option in a custom encoder registered usingserver.encoder()
, I realized that the current implementation either requires me to validate the compression options on each request, or trust that they are correct.Since neither option is desirable, I created this PR to extend the API with an optional
schema
to allow the validation logic to be applied only once, when the route is created.Let me know what you think?
Note that this only validates at the route level, and not at the connection level, since the connection already exits when adding the encoder.