Skip to content

Set cookie autoValue only when no value received #3879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hueniverse merged 1 commit into from
Jan 6, 2019
Merged

Set cookie autoValue only when no value received #3879

hueniverse merged 1 commit into from
Jan 6, 2019

Conversation

@dominykas
Copy link
Contributor

@dominykas dominykas commented Nov 17, 2018

Fixes #3831

@dominykas dominykas added the bug Bug or defect label Nov 17, 2018
@dominykas
Copy link
Contributor Author

dominykas commented Nov 17, 2018 •
edited
Loading

The node 11 failure is on master too - both master and this branch fail for me locally with node v11.2.0, but pass with node v11.1.0.

@dominykas dominykas mentioned this pull request Nov 17, 2018
Closed
@hueniverse hueniverse self-assigned this Jan 6, 2019
@hueniverse hueniverse added this to the 18.0.0 milestone Jan 6, 2019
@hueniverse hueniverse merged commit 713d879 into hapijs:master Jan 6, 2019
@hueniverse hueniverse mentioned this pull request Jan 18, 2019
Closed
@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@hueniverse hueniverse

Labels

bug Bug or defect

Projects

None yet

Milestone

18.0.0

Development

Successfully merging this pull request may close these issues.

State autoValue function overwrites existing cookie value

2 participants

@dominykas @hueniverse