Adding support for server timeouts #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| self._serverTimeoutId = setTimeout(function () { | ||
|
|
||
| sendResponse(Err.serverTimeout('Server is taking too long to respond')); | ||
| }, self.server.settings.timeout.server - (Date.now() - self._timestamp)); // Calculate the timeout from when the request was constructed |
There was a problem hiding this comment.
In case too long has passed, check for <= 0 and timeout immediately if needed.
|
|
||
| var funcsIterator = function (func, next) { | ||
|
|
||
| if (self._isReplied === true) { // Short circuit request if a reply already occurred |
There was a problem hiding this comment.
Nooooo... this might look like a good idea but we don't want to disturb the flow. For example, if you finished the handler but failed validation, and you exit in between, you would leave the crap in the cache (if it was cached).
| function (err) { | ||
| var reply = function (err) { | ||
|
|
||
| if (self._isReplied === true) { // Prevent any future responses to this request |
There was a problem hiding this comment.
why isn't this a local function variable?
|
Otherwise, ready to go. |
hueniverse
pushed a commit
that referenced
this pull request
Jan 31, 2013
Adding support for server timeouts
jmonster
pushed a commit
to jmonster/hapi
that referenced
this pull request
Feb 10, 2014
Adding support for server timeouts
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #360