Fixed jade compile issues and updated tests to verify fix. #814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hueniverse
pushed a commit
that referenced
this pull request
May 4, 2013
Fixed jade compile issues and updated tests to verify fix.
ghost
assigned 
jmonster
pushed a commit
to jmonster/hapi
that referenced
this pull request
Feb 10, 2014
Fixed jade compile issues and updated tests to verify fix.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently on master if try out the jade view example located in
examples/views/jadeyou will loading the index view triggers a 500 error.The first issue is the example is trying to load
.htmlas jade files.The second issue is associated with the use of
extendsin the example, to enable using shared layouts.The message for this error is as follows:
I have resolved this by updating the attribute used to pass the template filename to jade
lib/views.jsLastly I added a shared layout to the existing jade template test to ensure this doesn't crop up again.
Thanks