Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support node v18 and drop node v12 #50

Merged
merged 1 commit into from May 16, 2022
Merged

Support node v18 and drop node v12 #50

merged 1 commit into from May 16, 2022

Conversation

devinivy
Copy link
Member

@devinivy devinivy commented May 8, 2022 •
edited

  • Test on node v14+ and adopt some new syntax.
  • Update to node v18-compatible versions of hapi modules.
  • Made Heavy an ES6 class— I recommend reviewing with whitespace ignored.
  • Changed export to exports.Heavy rather than module.exports for more standard ESM usage.

If this looks good, this will go out as heavy v8.

@devinivy devinivy added breaking changes Change that can breaking existing code dependency Update module dependency labels May 8, 2022
@devinivy devinivy added this to the 8.0.0 milestone May 8, 2022
@devinivy devinivy merged commit 52f9e28 into v8 May 16, 2022
@devinivy devinivy deleted the drop-node-12-support-18 branch May 16, 2022 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geek geek geek approved these changes

Assignees
No one assigned
Labels
breaking changes Change that can breaking existing code dependency Update module dependency
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@devinivy @geek