Merge pull request #45 from adityabakle/master

Rename should throw an error for invalid property .
hapijs · Mar 19, 2014 · 7b14ca4 · 7b14ca4
2 parents 2c1f341 + 3bdfbd4
commit 7b14ca4
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/lib/index.js b/lib/index.js
@@ -437,6 +437,7 @@ exports.loadDirModules = function (path, excludeFiles, target) {      // target(
 
 exports.rename = function (obj, from, to) {
 
+    exports.assert(obj.hasOwnProperty(from),'Invalid property',from);
     obj[to] = obj[from];
     delete obj[from];
 };

diff --git a/test/index.js b/test/index.js
@@ -942,6 +942,18 @@ describe('Hoek', function () {
             expect(a.x).to.equal('c');
             done();
         });
+
+        it('should throw and invalid key in object error', function (done) {
+
+            var fn = function () {
+
+                var obj = {a:1, b:2};
+                Hoek.rename(obj, 'd', 'a');
+            };
+
+            expect(fn).to.throw('Invalid property d');
+            done();
+        });
     });
 
     describe('Timer', function () {