Support node v18 and drop node v12 #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinivy
added
breaking changes
Nargonath
approved these changes
May 1, 2022
cjihrig
approved these changes
May 1, 2022
hueniverse
reviewed
May 1, 2022
| @@ -1,5 +1,5 @@ | |||
| Copyright (c) 2011-2020, Sideway Inc, and project contributors | |||
| Copyright (c) 2011-2014, Walmart | |||
| Copyright (c) 2011-2022, Sideway Inc, and project contributors | |||
There was a problem hiding this comment.
Sideway copyright should be locked at 2011-2020 and project contributor moved to its own line like was done for Walmart.
There was a problem hiding this comment.
Good call, thanks for catching that. Fix is here: #378
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this looks good, this will go out as hoek v10.