Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: provide reference to TS types for export map #389

Merged
merged 1 commit into from Dec 5, 2023

Conversation

AndriiNyzhnyk
Copy link
Contributor

I have the same issue as described here. This PR fix reference to TS types for export map. After these changes, my TS project with node v20 and the default settings from @tsconfig/node20/tsconfig.json works as expected. In package.json mention "type": "module".

@kanongil kanongil added the types TypeScript type definitions label Sep 21, 2023
@kanongil kanongil mentioned this pull request Dec 5, 2023
@Nargonath Nargonath added the bug Bug or defect label Dec 5, 2023
@Nargonath Nargonath self-assigned this Dec 5, 2023
@Nargonath Nargonath merged commit faeca69 into hapijs:master Dec 5, 2023
9 checks passed
@Nargonath Nargonath linked an issue Dec 5, 2023 that may be closed by this pull request
@Nargonath Nargonath added this to the 11.0.4 milestone Dec 5, 2023
@Nargonath
Copy link
Member

Fix published in v11.0.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug or defect types TypeScript type definitions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing types in typescript with module resolution nodenext
3 participants