Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: import DT types #169

Merged
merged 1 commit into from Mar 13, 2023
Merged

feat: import DT types #169

merged 1 commit into from Mar 13, 2023

Conversation

Marsup
Copy link
Contributor

@Marsup Marsup commented Mar 7, 2023

This is an almost unmodified import from DT types.

I had to add joi to dev dependencies as its types were indirectly required to run the type tests.

devinivy
devinivy approved these changes Mar 13, 2023
View reviewed changes
Copy link
Member

@devinivy devinivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome :)

@Marsup Marsup added this to the 7.1.0 milestone Mar 13, 2023
@Marsup Marsup merged commit 72e461f into master Mar 13, 2023
18 checks passed
@Marsup Marsup deleted the feat/import-dt-types branch March 13, 2023 15:37
@Marsup Marsup self-assigned this Mar 13, 2023
@Marsup Marsup added feature New functionality or improvement types TypeScript type definitions labels Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nargonath Nargonath Nargonath approved these changes

@devinivy devinivy devinivy approved these changes

Assignees

@Marsup Marsup

Labels
feature New functionality or improvement types TypeScript type definitions
Projects
None yet
Milestone
7.1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Marsup @Nargonath @devinivy