Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optional string regex-based rule throws if key is missing #127

Closed
hueniverse opened this issue Sep 30, 2013 · 3 comments
Closed

Optional string regex-based rule throws if key is missing #127

hueniverse opened this issue Sep 30, 2013 · 3 comments
Labels
bug Bug or defect

Comments

@hueniverse
Copy link
Contributor

See hapijs/hapi#1078
@hueniverse hueniverse mentioned this issue Sep 30, 2013
Closed
hueniverse pushed a commit that referenced this issue Sep 30, 2013
test for #127
5fb50d6
@danielb2
Copy link
Contributor

danielb2 commented Oct 2, 2013

Is it sufficient just to check if value is undefined on this line? https://github.com/spumko/joi/blob/master/lib/types/string.js#L123

if (typeof(value) === 'undefined') { return null; }

It does fix the test.

@hueniverse
Copy link
Contributor Author

Sounds good. PR?

@danielb2 danielb2 mentioned this issue Oct 2, 2013
Merged
@danielb2
Copy link
Contributor

danielb2 commented Oct 2, 2013

updated pull request

hueniverse pushed a commit that referenced this issue Oct 2, 2013
Merge pull request #129 from danielb2/master
4e7bf7b 
Fixes #127: Optional string regex-based rule throws if key is missing
@yoitsro yoitsro mentioned this issue Feb 9, 2014
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Jan 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Bug or defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danielb2 @hueniverse