Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EdDSA (ed25519, ed448) support #48

Closed
mautematico opened this issue Aug 19, 2022 · 4 comments
Closed

EdDSA (ed25519, ed448) support #48

mautematico opened this issue Aug 19, 2022 · 4 comments
Labels
feature New functionality or improvement
Milestone

Comments

@mautematico
Copy link
Contributor

Support plan

  • is this issue currently blocking your project? (yes/no): yes
  • is this issue affecting a production system? (yes/no): no

Context

  • node version: LTS
  • module version: 2.1.1
  • environment (e.g. node, browser, native): node
  • used with (e.g. hapi application, another framework, standalone, ...): hapi application
  • any other relevant information:

What problem are you trying to solve?

According to documentation:
https://hapi.dev/module/jwt/api/?v=2.1.1#Key-algorithms-supported-by-jwt

supported public key algorithms are:

algorithms: ['RS256', 'RS384', 'RS512', 'PS256', 'PS384', 'PS512', 'ES256', 'ES384', 'ES512'];

it would be nice to also have support for EdDSA. Has it been considered on the roadmap? Is this something of your interest? it would be awesome to have hints on where it is needed to dig deeper to make it happening

Do you have a new or modified API suggestion to solve the problem?

No

@mautematico mautematico added the feature New functionality or improvement label Aug 19, 2022
@kanongil
Copy link

Yeah, not all algorithms from https://www.iana.org/assignments/jose/jose.xhtml are supported.

If someone is interested in implementing this, it is specified here: https://datatracker.ietf.org/doc/html/rfc8037

@lallenfrancisl
Copy link
Contributor

lallenfrancisl commented Aug 30, 2022

I can volunteer to try and put up a pr for this, haven't implemented RFCs before but will definitely give a try

This was referenced Oct 25, 2022
@mautematico mautematico changed the title ed25519 support EdDSA (ed25519, ed448) support Oct 26, 2022
@mautematico
Copy link
Contributor Author

would you please take a look at #53?

@Marsup Marsup added this to the 3.1.0 milestone Feb 4, 2023
@Marsup
Copy link
Contributor

Marsup commented Feb 4, 2023

Thanks a lot for the PR, it's now released.

@Marsup Marsup closed this as completed Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality or improvement
Projects
None yet
Development

No branches or pull requests

4 participants