Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .ts to the default extensions for --lint #1065

Closed
dominykas opened this issue Jul 24, 2023 · 0 comments · Fixed by #1069
Closed

Add .ts to the default extensions for --lint #1065

dominykas opened this issue Jul 24, 2023 · 0 comments · Fixed by #1069
Assignees
@Marsup
Labels
feature New functionality or improvement
Milestone
25.2.0

Comments

@dominykas
Copy link
Contributor

Support plan

  • is this issue currently blocking your project? (yes/no): no
  • is this issue affecting a production system? (yes/no): yes

Context

  • node version: ~18
  • module version: latest
  • environment (e.g. node, browser, native): node
  • used with (e.g. hapi application, another framework, standalone, ...): all over the place
  • any other relevant information:

What problem are you trying to solve?

Running lab with --lint does not lint *.ts files.

Do you have a new or modified API suggestion to solve the problem?

When running lab with --typescript, .ts should be added to the default extensions: https://github.com/hapijs/lab/blob/master/lib/linter/index.js#L35

Alt: always add .ts - same as .cjs / .mjs.

Happy to PR!
@dominykas dominykas added the feature New functionality or improvement label Jul 24, 2023
dominykas added a commit to dominykas/lab that referenced this issue Nov 14, 2023
@dominykas
feat: always lint .ts
b0462be 
Closes hapijs#1065

I took the simpler approach here - an alternative would be to only add `.ts` when `--typescript` is set, but I figure there's probably no harm in always doing this?
@dominykas dominykas mentioned this issue Nov 14, 2023
Merged
dominykas added a commit to dominykas/lab that referenced this issue Dec 15, 2023
@dominykas
feat: always lint .ts
2481675 
Closes hapijs#1065

I took the simpler approach here - an alternative would be to only add `.ts` when `--typescript` is set, but I figure there's probably no harm in always doing this?
Marsup pushed a commit that referenced this issue Jan 15, 2024
@dominykas @Marsup
feat: always lint .ts
8ed0636 
Closes #1065

I took the simpler approach here - an alternative would be to only add `.ts` when `--typescript` is set, but I figure there's probably no harm in always doing this?
@Marsup Marsup added this to the 25.2.0 milestone Jan 15, 2024
@Marsup Marsup self-assigned this Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Marsup Marsup

Labels
feature New functionality or improvement
Projects
None yet
Milestone
25.2.0
Development

Successfully merging a pull request may close this issue.

Always lint .ts dominykas/lab
2 participants
@dominykas @Marsup