New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Behavior on missing done #217
Comments
We consider testing sync code an anomaly and do require you define the argument and call it. I'm ok with a warning message, but don't think it is that important. But then again, I don't really want people to use lab... I'll let Wyatt make the call. |
@hueniverse It appears to be the way to go when you're using hapi though, isn't it ? |
Sadly, yes. I saw the mocha guys trying to fix this. The main point is that this is no longer my problem :-) |
I think a warning message is fine, we already warn for missing exports.lab |
We also exit on missing exports.lab, is it desired here ? I'd think so but you tell me. |
Ya, I think that makes sense to exit early with an error |
Fix #217: throw on invalid function declaration
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
Hello,
I noticed people coming from mocha often forget to declare a done for synchronous code.
I know we don't intend to copy mocha but it might be useful to at least warn the user if no parameter is declared. It would be less verbose to accept both styles but I guess you did it on purpose ?
The text was updated successfully, but these errors were encountered: