Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint Failures Return Exit Code Zero #287

Closed
tribou opened this issue Dec 26, 2014 · 5 comments
Closed

Lint Failures Return Exit Code Zero #287

tribou opened this issue Dec 26, 2014 · 5 comments
Assignees
@geek
Labels
feature New functionality or improvement

Comments

@tribou
Copy link
Contributor

tribou commented Dec 26, 2014

Wasn't sure if this was by design or not, but it would be helpful for CI tests to return a non-zero exit code if lint tests fail. Currently, coverage tests return non-zero, but lint tests do not.

Windows 7
node v0.10.33
npm v2.1.16
lab v5.1.1
@geek geek added the question label Dec 26, 2014
@geek geek self-assigned this Dec 26, 2014
@geek
Copy link
Member

geek commented Dec 26, 2014

This is by design for now. At the moment we want to provide more of a warning message than an actual failure, but if you want it to fail on lint errors perhaps we can add that as a configuration option?

@Marsup
Copy link
Contributor

Marsup commented Dec 26, 2014

Maybe thresholds on the number of errors and warnings?

@AdriVanHoudt
Copy link
Contributor

doing something like the coverage threshold would make sense

@geek geek added request and removed question labels Feb 16, 2015
@geek
Copy link
Member

geek commented Feb 16, 2015

@AdriVanHoudt @Marsup sounds like a winner to me... if something is so far off the linting style, fail it.

@Marsup Marsup closed this as completed in 9d30b27 Apr 27, 2015
@Marsup Marsup added feature New functionality or improvement and removed request labels Sep 21, 2019
@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@geek geek

Labels
feature New functionality or improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@geek @Marsup @tribou @AdriVanHoudt