Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a shareable config for ESLint #429

Merged
merged 1 commit into from Aug 24, 2015
Merged

Use a shareable config for ESLint #429

merged 1 commit into from Aug 24, 2015

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Aug 24, 2015

No description provided.

@AdriVanHoudt
Copy link
Contributor

👏 now I can remove my "extends": "./node_modules/lab/lib/linters/eslint/.eslintrc", lines haha

@devinivy
Copy link
Member

This is good news!!

@gergoerdosi
Copy link
Contributor

I like this, better than extending ./node_modules/lab/lib/linters/eslint/.eslintrc. However as this config is hapi specific (meaning the hapijs team sets the rules), shouldn't the module (eslint-config-hapi) be under the hapijs organization?

@AdriVanHoudt
Copy link
Contributor

@cjihrig is there a way to put the config and plugin into 1 npm module?

@geek
Copy link
Member

geek commented Aug 24, 2015

@cjihrig I do like the idea of the config being in the hapijs org

@geek geek added the feature New functionality or improvement label Aug 24, 2015
@geek geek added this to the 5.15.3 milestone Aug 24, 2015
@geek geek self-assigned this Aug 24, 2015
@cjihrig
Copy link
Contributor Author

cjihrig commented Aug 24, 2015

@AdriVanHoudt not currently. See the discussion in eslint/eslint#2518 and eslint/eslint#3458. I also find it frustrating, but it is what it is.

@AdriVanHoudt
Copy link
Contributor

oh gawd...

geek added a commit that referenced this pull request Aug 24, 2015
@geek
Merge pull request #429 from cjihrig/config
5519fb4 
Use a shareable config for ESLint
@geek geek merged commit 5519fb4 into hapijs:master Aug 24, 2015
@cjihrig cjihrig deleted the config branch August 24, 2015 19:53
@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@geek geek

Labels
feature New functionality or improvement
Projects
None yet
Milestone
5.16.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cjihrig @AdriVanHoudt @devinivy @gergoerdosi @geek