New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add describe.skip/only and it.skip/only #116
Conversation
By the way, that cleanup also has another reason : it guarantees only the before/after/... necessary to run the experiment/test (even with nesting) will run. |
Actually I thought of another way which is that last commit, it relies more on the experiments/tests options and doesn't clean the tree anymore. It might be closer to what the project is currently doing. I let you pick the best approach (if any :)). |
Other than feature parity with mocha (which I don't care about), what's the point of this? I can see how *.skip() is easier syntax, but what is only() good for?! |
I've spent weeks working with the existing grep feature, and it's so not user friendly. As said in the original issue, it will ease working with watchers as you don't have to modify your configuration every time you want to focus on a test. Grep also relies on strings which sometimes conflict, and it also executes unnecessary before/after but that might be a bug. I really find it more efficient, less going around in different files to reconfigure your tests for such occasions where you need it. |
It may not fill the need for for example
or
|
For me, the main goal of |
@hueniverse Take that as a no ? |
Take that as I'll do it my own way... :-) |
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
skip
is only a wrapper around the already existing skip option, nothing much to say here.only
is more tricky, so feel free to review commits separately.I've tried to be the least intrusive but I'm not sure you'll like me hooking onto the Lab object.
Anyway I went for a cleanup of the testing tree before running the tests because it feels like what we would want (as opposed to dozens of tests marked as skipped).
I hope that's more or less what you would have done.
Closes #110