Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WHATWG Encoding API globals #833

Merged
merged 1 commit into from
May 13, 2018

Conversation

MarkTiedemann
Copy link
Contributor

TextEncoder and TextDecoder may become global variables in Node 11.

I don't expect this PR to be merged now, I'm just sending this as a tiny, early heads-up. 🙂

Issue: nodejs/node#20365
PR: nodejs/node#20662

Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@geek geek self-assigned this May 13, 2018
@geek geek added the bug Bug or defect label May 13, 2018
@geek geek added this to the 15.4.5 milestone May 13, 2018
@geek geek merged commit 3e4a37f into hapijs:master May 13, 2018
@geek
Copy link
Member

geek commented May 13, 2018

@MarkTiedemann and @cjihrig this is published as 15.4.5

@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bug or defect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants