Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "podium" event source #65

Closed
kanongil opened this issue Oct 22, 2020 · 1 comment
Closed

Remove "podium" event source #65

kanongil opened this issue Oct 22, 2020 · 1 comment
Labels
breaking changes Change that can breaking existing code feature New functionality or improvement
Milestone

Comments

@kanongil
Copy link
Contributor

Support plan

  • is this issue currently blocking your project? (yes/no): no
  • is this issue affecting a production system? (yes/no): no

Context

  • node version: any
  • module version: 4.x
  • environment (e.g. node, browser, native): any
  • used with (e.g. hapi application, another framework, standalone, ...): hapi
  • any other relevant information:

What problem are you trying to solve?

Simpler module maintenance. Completely avoids the issue in #64.

Do you have a new or modified API suggestion to solve the problem?

Remove podium.registerPodium() method, and the Podium argument handling from constructor and podium. registerEvent().

There is no direct usage of this feature inside the hapijs ecosystem. It is however exposed through server.events() in hapi, so that support would need to go as well. This feature is already problematic, as it requires the caller to use the exact same instance of the Podium module, as hapi itself. Otherwise it will fail the instanceof check, and be treated as an event object.

There might also be another bug in the feature, where late event registrations are not handled.

@kanongil kanongil added feature New functionality or improvement breaking changes Change that can breaking existing code labels Oct 22, 2020
@kanongil kanongil changed the title Remove podium event source Remove "podium" event source Nov 5, 2020
kanongil added a commit to kanongil/podium that referenced this issue Oct 16, 2021
@hueniverse
Copy link
Contributor

This was used in hapi for a while. If it is no longer used, I see no reason to keep it.

@devinivy devinivy added this to the 5.0.0 milestone Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking changes Change that can breaking existing code feature New functionality or improvement
Projects
None yet
Development

No branches or pull requests

3 participants