array holes incorrectly copied into object on large index

[dougwilson]

The following:

qs.parse('a[2]=2&a[999999999]=1')

results in the following

{ a: { '0': undefined, '1': undefined, '2': '2', '999999999': '1' } }

Since 0 and 1 were actually holes in the array (i.e. !(0 in arr)), they should not have properties created from them in the object. I would expect:

{ a: { '2': '2', '999999999': '1' } }

which is the output if you had them backwards: qs.parse('a[999999999]=1&a[2]=2')

TL;DR I think qs.parse('a[2]=2&a[999999999]=1') should have the same resulting object (with the same existing properties) as qs.parse('a[999999999]=1&a[2]=2').

[nlf]

Ah, good catch. Thanks for reporting it. I'll get it taken care of

[dougwilson]

@nlf by the way, you guys are awesome :)

[nlf]

Closed via f93ff35

[nlf]

Just published it as v1.0.2, thanks @dougwilson!