Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rev'ed qs dependency to 1.0.0 which contain updates and security fixes #1048

Closed
wants to merge 1 commit into from

Conversation

altsang
Copy link

@altsang altsang commented Aug 5, 2014

new qs module published to npm from https://github.com/hapijs/qs, contains updates and security fixes to issues such as - tj/node-querystring#104 in original repo

/to @dougwilson

@dougwilson
Copy link
Contributor

Hi!

Can you point me to a change log? I tried to just diff it, but it seems it's completely rewritten so I cannot tell what all the changes are. If not, I will try to read the code and run some internal test suites against the new major version just so I am aware of the potential issues people will start firing over here from the change.

I believe there are some dependencies of connect as well that need to get their qs bumped, but I can do that once I figure out the differences :)

@dougwilson
Copy link
Contributor

Hi @altsang any update on this? Change log?

@dougwilson
Copy link
Contributor

I am waiting on ljharb/qs#5 first; it's the only "bug" that I've found so far comparing the two different versions.

dougwilson added a commit that referenced this pull request Aug 6, 2014
@dougwilson dougwilson closed this Aug 6, 2014
@mstuart
Copy link

mstuart commented Aug 6, 2014

Did you republish 2.24.3? Doesn't seem to have the newest qs. http://registry.npmjs.org/connect

@dougwilson
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants