New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add validation schema to shot #71
Conversation
dispatchFunc: dispatchFunc, | ||
options: options, | ||
callback: callback | ||
}, Schema); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{ options, callback }
looks nicer
url: internals.url.required(), | ||
headers: Joi.object(), | ||
payload: Joi.any(), | ||
simulate: Joi.object(), // add these |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. Add these... :-)
Going to finish it? |
Cheers for the reminder @hueniverse - added the simulate options. |
Hmm. Now that I think about it, this will make things very slow when |
Yeah true, kind of the opposite direction to hapijs/hapi#2751 ( Could only run validate when |
Just needs a config variable or some sort of server.app attribute or similar. |
Agreed - I wouldn't ever want nes requests to pass through this validation step. An |
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
Fixes #66