Fix timeouts for multipart payloads #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnbrett
added a commit
that referenced
this pull request
Nov 14, 2015
Fix timeouts for multipart payloads
| @@ -1467,4 +1467,40 @@ describe('parse()', () => { | |||
| }); | |||
| }); | |||
| }); | |||
|
|
|||
| it('will timeout correctly for a multipart payload with output as stream', (done) => { | |||
There was a problem hiding this comment.
We usually use present progressive for the text. E.g. "times out a multipart payload with stream output". Not a big deal just more consistent.
There was a problem hiding this comment.
ah yep - should have spotted that thanks! Updated this and above.
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a fix for multipart payload timeouts which fixes #19