Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timeouts for multipart payloads #23

Merged
merged 4 commits into from Nov 14, 2015

Conversation

@johnbrett
Copy link
Contributor

johnbrett commented Nov 14, 2015

This PR contains a fix for multipart payload timeouts which fixes #19

johnbrett added 4 commits Nov 14, 2015
Adding failing tests for #19
@johnbrett johnbrett self-assigned this Nov 14, 2015
@johnbrett johnbrett added the bug label Nov 14, 2015
johnbrett added a commit that referenced this pull request Nov 14, 2015
Fix timeouts for multipart payloads
@johnbrett johnbrett merged commit 19114a9 into master Nov 14, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@johnbrett johnbrett added this to the 3.0.1 milestone Nov 14, 2015
@hueniverse hueniverse deleted the issue-payload-timeout branch Nov 14, 2015
@@ -1467,4 +1467,40 @@ describe('parse()', () => {
});
});
});

it('will timeout correctly for a multipart payload with output as stream', (done) => {

This comment has been minimized.

Copy link
@hueniverse

hueniverse Nov 14, 2015

Member

We usually use present progressive for the text. E.g. "times out a multipart payload with stream output". Not a big deal just more consistent.

This comment has been minimized.

Copy link
@johnbrett

johnbrett Nov 14, 2015

Author Contributor

ah yep - should have spotted that thanks! Updated this and above.

clientTimeoutId = setTimeout(() => {

return next(Boom.clientTimeout());
}, clientTimeout);

This comment has been minimized.

Copy link
@hueniverse

hueniverse Nov 14, 2015

Member

Better written as clientTimeoutId = setTimeout(() => next(Boom.clientTimeout(), clientTimeout); on a single line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.