Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes https://github.com/hapijs/topo/issues/23 #24

Closed
wants to merge 1 commit into from
Closed

Fixes https://github.com/hapijs/topo/issues/23 #24

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jul 15, 2016

No description provided.

@Marsup
Copy link
Contributor

Marsup commented Jul 15, 2016

You should put a test on that unless you're open to regressions.

@devinivy
Copy link
Member

devinivy commented Jul 16, 2016

This looks pretty good– I'd like to make sure there aren't other similar issues. It might make sense to instead use Object.create(null) to get an object with an empty prototype, rather than performing hasOwnProperty() checks through the code. Unless you've already done the work @vam, I'm happy to provide the regression test.

@devinivy
Copy link
Member

Turns out there were some more issues around using groups named after properties of Object.prototype. I'm replacing this PR with #25, which also contains a regression test. @vam if you have a moment, let me know if it resolves your original issue.

@devinivy devinivy closed this Jul 16, 2016
@ghost
Copy link
Author

ghost commented Jul 19, 2016

@devinivy +1 on the solution with Object.create(null). Yes that solved my problem. Thanks!

@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bug or defect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants