Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4.0.0 Release Notes #45

Closed
geek opened this issue Aug 29, 2014 · 2 comments
Closed

4.0.0 Release Notes #45

geek opened this issue Aug 29, 2014 · 2 comments
Assignees
@geek
Labels
breaking changes Change that can breaking existing code release notes Major release documentation
Milestone
4.0.0

Comments

@geek
Copy link
Member

geek commented Aug 29, 2014

Summary

The intent of v4.0.0 is to help mitigate bottlenecks when using Wreck and agent pooling. By default, on node v0.10, maxSockets is set to 5. This can cause slowness if there are a lot of requests that need to be made as only 5 sockets will get to be used. In node v0.11 this default value is changed to Infinity. Wreck v4.0.0 follows this lead and now defaults the maxSockets to Infinity.

Breaking Change

To avoid overwriting the maxSockets value in the node http and https globalAgent Wreck creates new agents. These agents are exported under the agents object in Wreck. If you need to change the maxSockets value from Infinity then you will need to change either Wreck.agents.http.maxSockets or Wreck.agents.https.maxSockets.

In other words, changing the globalAgent no longer has an impact on the default agent used by Wreck.

Enhancement

Agent pooling can now be disabled by passing false for the value of agent when calling a Wreck request function.
@geek geek self-assigned this Aug 29, 2014
@geek geek added this to the 4.0.0 milestone Aug 29, 2014
@geek
Copy link
Member Author

geek commented Aug 29, 2014

Closed via https://github.com/hapijs/wreck/releases/tag/v4.0.0

@geek geek closed this as completed Aug 29, 2014
@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@geek geek

Labels
breaking changes Change that can breaking existing code release notes Major release documentation
Projects
None yet
Milestone
4.0.0
Development

No branches or pull requests
1 participant
@geek