Wrap error response with Boom

[geek]

Fixes #82

[kanongil]

Sorry, but this is a terrible implementation of the feature.

There are existing use-cases that requires information from the payload on status code errors, which is now impossible to retrieve. Further, all the helper methods don't even provide a way to access any headers on these errors.

As it is, something like h2o2 is not able to upgrade, and will need to find a replacement.

[AdriVanHoudt]

@kanongil I agree, would Boom.wrap not be better for this?

[geek]

@kanongil and @AdriVanHoudt you have access to the full response object, which is passed as the second argument in the callback. Additionally, the response event provides the original request and response objects.

I am open to a better solution if either of you want to submit a PR.

[kanongil]

Full access, yes – but it has been aborted. Which means I won't be able to get the payload.

[kanongil]

As far as I can tell, this feature can only ever work for the helper methods, and the response behavior needs to be reverted.

[geek]

I am open to a better solution if either of you want to submit a PR.

[kanongil]

My PR would just be a revert of this commit. Then you can always create new option for this, as suggested in #82.

[geek]

@kanongil doesn't this solve the issue? #163

[lock]

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.