Simplify logic for looking-up boom error type #11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #10 I noticed there there might be an opportunity to simplify some of the logic used to look-up a boom error type from an objection error type.
If I understand correctly this logic is looking for an exact constructor match:
The idea here is to use a
Map
keyed by objection error classes to do a direct lookup on the error's constructor to see if it is of one of those classes.