Upgrade lab to its latest version #79
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinivy
reviewed
Oct 25, 2018
.travis.yml
Outdated
| - "4" | ||
| - "6" | ||
| - "node" | ||
| - "7.6.0" |
There was a problem hiding this comment.
How do we feel about following hapi to test 8, 10, and latest?
There was a problem hiding this comment.
I think these versions are still very popular.
There was a problem hiding this comment.
Saw that. Was wondering too. It'd probably make more sense. I'll copy them.
There was a problem hiding this comment.
(Both v7 and v9 are already EOL: https://github.com/nodejs/Release)
There was a problem hiding this comment.
Ah well! That would be why then, haha!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
17.x.x) to get tests workingasync/await(100% sure it could be better), at least forbefore/afterondescribe('bin')node >= 7.6.0(because ofasync/await)4.0.0as there's a breaking change regarding node's version