Register caches before plugins #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some plugins may have cache dependencies. In order to make cache configurations available to plugins, this commit switches the order of registration. Closes #38
devinivy
reviewed
Apr 15, 2018
| engine: null, | ||
| name: '' | ||
| } | ||
| }, | ||
| { | ||
| place: 'plugins', | ||
| method: 'register', |
There was a problem hiding this comment.
The purpose of the after property is to express exactly this sort of rule: "plugin registrations come after cache provisions." Can you also add after: ['caches'] to this plugin registrations item? It's described in a bit more detail here, but I am happy to elaborate!
|
Thank you for your contribution! I had one little comment, but this generally looks great 👍I appreciate the docs update. |
|
Thanks for the feedback, you are welcome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some plugins may have cache dependencies. In order to make cache
configurations available to plugins, this commit switches the order of
registration.
Closes #38