Fix inferring hc file location within ESM project #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinivy
commented
Dec 5, 2022
devinivy
commented
Dec 5, 2022
| @@ -101,7 +101,7 @@ describe('HauteCouture', () => { | |||
| }); | |||
| }; | |||
|
|
|||
| const bigServer = Hapi.server(); | |||
| const bigServer = Hapi.server({ host: 'localhost' }); | |||
There was a problem hiding this comment.
This fixes an environment-specific issue with the subscriptions test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue with inferring the location of the hc file when
dirnamewas not explicitly passed in an ESM project. This resolves that issue. Thanks to @afgallo for the clear reproduction https://github.com/afgallo/hpal-esmodule