Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support command descriptions specified as a function, publicize ctx.colors #48

Merged
merged 3 commits into from Aug 6, 2020
Merged

Support command descriptions specified as a function, publicize ctx.colors #48

merged 3 commits into from Aug 6, 2020

Conversation

devinivy
Copy link
Member

@devinivy devinivy commented Aug 5, 2020

This PR consists of two small enhancements that work together, as recommended by @damusix in #47:

  • Make the ctx.colors CLI formatting utilities officially part of the public API.
  • Allow command descriptions to be specified as a function (ctx) => description (with access to those formatting utilities).

@devinivy devinivy mentioned this pull request Aug 5, 2020
Closed
@coveralls
Copy link

coveralls commented Aug 5, 2020 •
edited

Coverage Status

Coverage remained the same at 100.0% when pulling ddb6230 on cmd-description-as-function into a924c5d on master.

damusix
damusix approved these changes Aug 5, 2020
View reviewed changes
Copy link

@damusix damusix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you my friend :)

@devinivy devinivy merged commit 21eac50 into master Aug 6, 2020
@devinivy devinivy self-assigned this Aug 6, 2020
@devinivy devinivy added this to the 2.6.0 milestone Aug 6, 2020
@devinivy devinivy deleted the cmd-description-as-function branch August 6, 2020 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damusix damusix damusix approved these changes

Assignees

@devinivy devinivy

Labels
enhancement
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@devinivy @coveralls @damusix