Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #13
@devinivy I added the odd new lines in the testing file to deal with that test failing on node 10 (v.10.15.3) and 12 (v.12.2.0).
The test would complete, all assertions would pass, but would then error out in the
onCleanup
callback with anECONNRESET
error. As far as I can tell, this happens because the http2 client's response stream hasn't closed, so callingclient.destroy()
force-ends that stream, triggering anECONNRESET
. Note that callingclient.close()
, the "graceful/clean" version of that call, closes the stream without error (though takes some extra time to complete).The current approach ensures the response closes by consuming it via the data handler, which seems to enable the stream to end (without the data handler, the
Toys.event(request, 'end')
never fulfills, causing the test to timeout. I think? God, I dunno, very quickly got out of my depth.My bad if I just made a mess of things here![:trollface: :trollface:](https://github.githubassets.com/images/icons/emoji/trollface.png)