-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Failed to parse pg_controldata output #26
Comments
[resolve]:
reboot
|
Hi @meiyifei ! So it seems that the problem is with Thanks for your feedback. Marking this issue as a bug and assigning it to the next release, I think we should be able to have a fix that soon! |
DimCitus
changed the title
【failed】Failed to get PGDATA either from the environment or from --pgdata
BUG: Failed to parse pg_controldata output
Jun 18, 2019
DimCitus
pushed a commit
that referenced
this issue
Jun 19, 2019
We parse the output of pg_controldata and expect English output. Force the environment to be in C locale when calling pg_controldata so that we do not depend on the user locale settings here. The other output parsing we do is on pg_ctl --version, where we only parse the version string. As that's only digits and dots ([[:digit:].]+), we don't need to set the LANG=C in that case. I think. At least this patch does nothing for this case. Fix #26.
DimCitus
added a commit
that referenced
this issue
Jun 20, 2019
We parse the output of pg_controldata and expect English output. Force the environment to be in C locale when calling pg_controldata so that we do not depend on the user locale settings here. The other output parsing we do is on pg_ctl --version, where we only parse the version string. As that's only digits and dots ([[:digit:].]+), we don't need to set the LANG=C in that case. I think. At least this patch does nothing for this case. Fix #26.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The text was updated successfully, but these errors were encountered: