QA work following the docs quickstart #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to use the environment value as a fallback when the user is not providing us with --pgport, but we don't require the value to be there.
We need to change to be reflected so that the postgresql configuration file we prepare contains the absolute path to the OpenSSL self-signed certificate, when we create one.
Otherwise we get an error to create the startup.log file with the initial logs from starting Postgres.
In particular we need to be careful about using --auth and --ssl-self-signed options when creating the monitor and every other node.
mtuncer
reviewed
Mar 16, 2020
| @@ -578,11 +578,10 @@ monitor_config_set_setting(MonitorConfig *config, | |||
| bool | |||
| monitor_config_update_with_absolute_pgdata(MonitorConfig *config) | |||
| { | |||
| PostgresSetup pgSetup = config->pgSetup; | |||
| PostgresSetup *pgSetup = &(config->pgSetup); | |||
There was a problem hiding this comment.
change of behavior, instead of copy of the data we are working on the actual config. Is this intentional ?
There was a problem hiding this comment.
It is yeah, otherwise we don't use the absolute path and then we fail to use the proper PATH to the self-signed certificate that has been created when the users has given us a relative path to pgdata, such as --pgdata ./monitor as in the documentation.
mtuncer
approved these changes
Mar 16, 2020
DimCitus
added a commit
that referenced
this pull request
Mar 19, 2020
* Don't error out when PGPORT does not exists in the environment. We want to use the environment value as a fallback when the user is not providing us with --pgport, but we don't require the value to be there. * Forward the absolute PGDATA change. We need to change to be reflected so that the postgresql configuration file we prepare contains the absolute path to the OpenSSL self-signed certificate, when we create one. * Review the FOPEN_FLAGS_A to include O_RDWR. Otherwise we get an error to create the startup.log file with the initial logs from starting Postgres. * Fix pg_autoctl show uri on the monitor. * Quickstart review with the new code. In particular we need to be careful about using --auth and --ssl-self-signed options when creating the monitor and every other node. * Adding compat write open mode O_TRUNC.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow the Quickstart and fix everything that we broke in the release making.