SMC-4749: created fromRemotePeer function for readability

happner · Dec 8, 2021 · 1e7dec6 · 1e7dec6
1 parent 37e1cf3
commit 1e7dec6
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/lib/brokerage.js b/lib/brokerage.js
@@ -105,8 +105,9 @@ Brokerage.prototype.__updateInjectedComponent = function(changedComponent, whatC
     .then(() => {
       this.__updateInjectedElements(changedComponent, updatedElement);
       this.logger.info('element re-injected: ' + changedComponent.component.name);
-      if (whatChanged.meshName !== this.__mesh._mesh.config.name) {
+      if (this.__fromRemotePeer(whatChanged)) {
         // pre-injected placeholders would be created by this peer itself
+        // and so they should be ignored for satisfaction
         this.__satisfiedElementNames.push(changedComponent.component.name);
       }
       this.__checkDependenciesSatisfied();
@@ -116,6 +117,10 @@ Brokerage.prototype.__updateInjectedComponent = function(changedComponent, whatC
     });
 };
 
+Brokerage.prototype.__fromRemotePeer = function(whatChanged) {
+  return whatChanged.meshName !== this.__mesh._mesh.config.name;
+};
+
 Brokerage.prototype.__updateInjectedElements = function(changedComponent, updatedElement) {
   const changedComponentIndex = this.__injectedElements.indexOf(changedComponent);