Merge pull request #258 from happo/initialization-errors

Add timeout waiting for `onBundleReady`

package.json

@@ -1,6 +1,6 @@
 {
   "name": "happo.io",
-  "version": "8.3.3",
+  "version": "8.4.0-alpha",
   "description": "Visual diffing for UI components",
   "main": "./build/index.js",
   "engines": {

src/JSDOMDomProvider.js

@@ -55,8 +55,15 @@ export default class JSDOMDomProvider {
   }
 
   async init({ targetName }) {
-    await new Promise((resolve) => {
-      this.dom.window.onBundleReady = resolve;
+    await new Promise((resolve, reject) => {
+      const timeout = setTimeout(() =>
+        reject(new Error('Failed to load Happo bundle within 10s. Check console log for errors.')),
+      10000);
+
+      this.dom.window.onBundleReady = () => {
+        clearTimeout(timeout);
+        resolve();
+      };
     });
     return this.dom.window.happoProcessor.init({ targetName });
   }

test/integrations/error-test.js

@@ -151,17 +151,19 @@ describe('with generated examples that fail to initialize', () => {
     config.type = 'react';
   });
 
-  xdescribe('with the puppeteer plugin', () => {
-    beforeEach(() => {
-      config.plugins = [happoPluginPuppeteer()];
-    });
-
-    it('logs an error', async () => {
+  it('throws a timeout error', async () => {
+    try {
       await subject();
-      expect(console.log.mock.calls.length).toBe(1);
-      expect(console.log.mock.calls[0][0]).toEqual(
-        'Uncaught ReferenceError: foo is not defined',
+    } catch (e) {
+      expect(e.message).toMatch(
+        /Failed to load Happo bundle within/,
       );
-    });
+      expect(console.error.mock.calls[1][0]).toMatch(/foo is not defined/);
+      return;
+    }
+
+
+    // If we end up here, something is wrong
+    expect(false).toBe(true);
   });
 });