feat: add callback to be able store compare result information #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trotzig
reviewed
Sep 14, 2022
src/commands/compareReports.js
Outdated
|
|
||
| const secondCompareResult = await makeCompareCall(false); | ||
| if(afterComparison && typeof afterComparison === "function") { | ||
| afterComparison(secondCompareResult); |
There was a problem hiding this comment.
Make sure to add the callback on line 52 as well. That's the more common case, right here is where there is a compareThreshold used. Which is rare.
There was a problem hiding this comment.
I added also condition for isAsync
| @@ -108,7 +108,13 @@ export default async function compareReports( | |||
| // Make second compare call to finalize the deep compare. The second call will | |||
| // cause a status to be posted to the PR (if applicable). Any ignored diffs | |||
| // from the first call will be excluded from the result. | |||
| const secondCompareResult = await makeCompareCall(false); | |||
| log(secondCompareResult.summary); | |||
There was a problem hiding this comment.
Move this line down as well.
wokayme
force-pushed
the
feat(comparison)--add-callback-to-be-able-store-compare-result-information
branch
from
d2a94a9
to
cfd4a5c
Compare
trotzig
approved these changes
Sep 14, 2022
src/commands/compareReports.js
Outdated
| @@ -48,6 +48,10 @@ export default async function compareReports( | |||
| typeof compareThreshold === 'number' || dryRun, | |||
| ); | |||
| if (typeof compareThreshold !== 'number' || isAsync) { | |||
|
|
|||
| if(!isAsync && afterSyncComparison && typeof afterSyncComparison === "function") { | |||
| afterSyncComparison(firstCompareResult); | |||
There was a problem hiding this comment.
I suggest we await the results so that you can run an asynchronous function.
|
I am happy that I could help. And I am waiting for tomorrow release ;) |
|
This was released in version 8.1.0. 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example of implementation for following idea:
#241