Added status check

happy-hamster · May 5, 2020 · 7cb4177 · 7cb4177
1 parent 3ccc1bd
commit 7cb4177
Show file tree

Hide file tree

Showing 5 changed files with 21 additions and 0 deletions.
diff --git a/src/test/java/de/sakpaas/backend/v2/controller/EndpointAddFavoriteByLocationIdTest.java b/src/test/java/de/sakpaas/backend/v2/controller/EndpointAddFavoriteByLocationIdTest.java
@@ -85,6 +85,7 @@ void testFound() throws Exception {
 
     mockMvc.perform(post("/v2/users/self/favorites/1000")
         .header("Authorization", AUTHENTICATION_VALID))
+        .andExpect(status().isOk())
         .andExpect(super.expectLocation(location))
         .andExpect(jsonPath("$.favorite").value(true));
 
@@ -120,6 +121,7 @@ void testAlreadyFavorite() throws Exception {
 
     mockMvc.perform(post("/v2/users/self/favorites/1000")
         .header("Authorization", AUTHENTICATION_VALID))
+        .andExpect(status().isOk())
         .andExpect(super.expectLocation(location))
         .andExpect(jsonPath("$.favorite").value(true));
 
@@ -155,6 +157,7 @@ void testOccupancy() throws Exception {
 
     mockMvc.perform(post("/v2/users/self/favorites/1000")
         .header("Authorization", AUTHENTICATION_VALID))
+        .andExpect(status().isOk())
         .andExpect(super.expectLocation(location))
         .andExpect(jsonPath("$.favorite").value(true))
         .andExpect(jsonPath("$.occupancy.value").value(occupancy.getOccupancy()))

diff --git a/src/test/java/de/sakpaas/backend/v2/controller/EndpointGetLocationByIdTest.java b/src/test/java/de/sakpaas/backend/v2/controller/EndpointGetLocationByIdTest.java
@@ -72,6 +72,7 @@ void testFound() throws Exception {
 
     mockMvc.perform(get("/v2/locations/1000")
         .header("Authorization", AUTHENTICATION_VALID))
+        .andExpect(status().isOk())
         .andExpect(super.expectLocation(location))
         .andExpect(jsonPath("$.favorite").value(false))
         .andExpect(jsonPath("$.occupancy.value").doesNotExist())
@@ -80,6 +81,7 @@ void testFound() throws Exception {
 
     mockMvc.perform(get("/v2/locations/1000"))
         // No Authentication
+        .andExpect(status().isOk())
         .andExpect(super.expectLocation(location))
         .andExpect(jsonPath("$.favorite").doesNotExist())
         .andExpect(jsonPath("$.occupancy.value").doesNotExist())
@@ -105,6 +107,7 @@ void testFoundFavorite() throws Exception {
 
     mockMvc.perform(get("/v2/locations/1000")
         .header("Authorization", AUTHENTICATION_VALID))
+        .andExpect(status().isOk())
         .andExpect(super.expectLocation(location))
         .andExpect(jsonPath("$.favorite").value(true))
         .andExpect(jsonPath("$.occupancy.value").doesNotExist())
@@ -113,6 +116,7 @@ void testFoundFavorite() throws Exception {
 
     mockMvc.perform(get("/v2/locations/1000"))
         // No Authentication
+        .andExpect(status().isOk())
         .andExpect(super.expectLocation(location))
         .andExpect(jsonPath("$.favorite").doesNotExist())
         .andExpect(jsonPath("$.occupancy.value").doesNotExist())
@@ -138,6 +142,7 @@ void testFoundOccupancy() throws Exception {
 
     mockMvc.perform(get("/v2/locations/1000")
         .header("Authorization", AUTHENTICATION_VALID))
+        .andExpect(status().isOk())
         .andExpect(super.expectLocation(location))
         .andExpect(jsonPath("$.favorite").value(false))
         .andExpect(jsonPath("$.occupancy.value").value(occupancy.getOccupancy()))
@@ -146,6 +151,7 @@ void testFoundOccupancy() throws Exception {
 
     mockMvc.perform(get("/v2/locations/1000"))
         // No Authentication
+        .andExpect(status().isOk())
         .andExpect(super.expectLocation(location))
         .andExpect(jsonPath("$.favorite").doesNotExist())
         .andExpect(jsonPath("$.occupancy.value").value(occupancy.getOccupancy()))

diff --git a/src/test/java/de/sakpaas/backend/v2/controller/EndpointGetLocationsByCoordinatesTest.java b/src/test/java/de/sakpaas/backend/v2/controller/EndpointGetLocationsByCoordinatesTest.java
@@ -100,10 +100,12 @@ void testEmpty() throws Exception {
 
     mockMvc.perform(get("/v2/locations?latitude=0.0&longitude=0.0")
         .header("Authorization", AUTHENTICATION_VALID))
+        .andExpect(status().isOk())
         .andExpect(jsonPath("$", hasSize(0)));
 
     mockMvc.perform(get("/v2/locations?latitude=0.0&longitude=0.0"))
         // No Authentication
+        .andExpect(status().isOk())
         .andExpect(jsonPath("$", hasSize(0)));
   }
 
@@ -132,11 +134,13 @@ void testFound() throws Exception {
 
     mockMvc.perform(get("/v2/locations?latitude=42.0&longitude=7.0")
         .header("Authorization", AUTHENTICATION_VALID))
+        .andExpect(status().isOk())
         .andExpect(super.expectLocationList(locations))
         .andExpect(jsonPath("$", hasSize(1)));
 
     mockMvc.perform(get("/v2/locations?latitude=42.0&longitude=7.0"))
         // No Authentication
+        .andExpect(status().isOk())
         .andExpect(super.expectLocationList(locations))
         .andExpect(jsonPath("$", hasSize(1)));
   }
@@ -168,13 +172,15 @@ void testFavorite() throws Exception {
 
     mockMvc.perform(get("/v2/locations?latitude=42.0&longitude=7.0")
         .header("Authorization", AUTHENTICATION_VALID))
+        .andExpect(status().isOk())
         .andExpect(super.expectLocationList(locations))
         .andExpect(jsonPath("$", hasSize(2)))
         .andExpect(jsonPath("$.[?(@.id==1000)].favorite").value(true))
         .andExpect(jsonPath("$.[?(@.id==2000)].favorite").value(false));
 
     mockMvc.perform(get("/v2/locations?latitude=42.0&longitude=7.0"))
         // No Authentication
+        .andExpect(status().isOk())
         .andExpect(super.expectLocationList(locations))
         .andExpect(jsonPath("$", hasSize(2)))
         // The result is a list and will not automatically unpacked with nullValue()
@@ -202,6 +208,7 @@ void testOccupancy() throws Exception {
     mockMvc.perform(
         get("/v2/locations/1000")
             .header("Authorization", AUTHENTICATION_VALID))
+        .andExpect(status().isOk())
         .andExpect(super.expectLocation(location))
         .andExpect(jsonPath("$.favorite").value(false))
         .andExpect(jsonPath("$.occupancy.value").value(occupancy.getOccupancy()))
@@ -211,6 +218,7 @@ void testOccupancy() throws Exception {
     mockMvc.perform(
         get("/v2/locations/1000"))
         // No Authentication
+        .andExpect(status().isOk())
         .andExpect(super.expectLocation(location))
         .andExpect(jsonPath("$.favorite").doesNotExist())
         .andExpect(jsonPath("$.occupancy.value").value(occupancy.getOccupancy()))

diff --git a/src/test/java/de/sakpaas/backend/v2/controller/EndpointListFavoritesTest.java b/src/test/java/de/sakpaas/backend/v2/controller/EndpointListFavoritesTest.java
@@ -83,6 +83,7 @@ void testFound() throws Exception {
 
     mockMvc.perform(get("/v2/users/self/favorites")
         .header("Authorization", AUTHENTICATION_VALID))
+        .andExpect(status().isOk())
         .andExpect(super.expectLocationList(locations))
         .andExpect(jsonPath("$", hasSize(2)))
         .andExpect(jsonPath("$[*].favorite").value(everyItem(equalTo(true))));

diff --git a/src/test/java/de/sakpaas/backend/v2/controller/EndpointRemoveFavoriteByLocationIdTest.java b/src/test/java/de/sakpaas/backend/v2/controller/EndpointRemoveFavoriteByLocationIdTest.java
@@ -131,6 +131,7 @@ void testFavoriteFound() throws Exception {
 
     mockMvc.perform(delete("/v2/users/self/favorites/1000")
         .header("Authorization", AUTHENTICATION_VALID))
+        .andExpect(status().isOk())
         .andExpect(super.expectLocation(location))
         .andExpect(jsonPath("$.favorite").value(false));
 
@@ -166,6 +167,7 @@ void testMultipleFavoritesFound() throws Exception {
 
     mockMvc.perform(delete("/v2/users/self/favorites/1000")
         .header("Authorization", AUTHENTICATION_VALID))
+        .andExpect(status().isOk())
         .andExpect(super.expectLocation(location))
         .andExpect(jsonPath("$.favorite").value(false));
 
@@ -201,6 +203,7 @@ void testOccupancy() throws Exception {
 
     mockMvc.perform(delete("/v2/users/self/favorites/1000")
         .header("Authorization", AUTHENTICATION_VALID))
+        .andExpect(status().isOk())
         .andExpect(super.expectLocation(location))
         .andExpect(jsonPath("$.favorite").value(false))
         .andExpect(jsonPath("$.occupancy.value").value(occupancy.getOccupancy()))